Skip to content

option: use netip.Prefix for DaemonConfig.ExcludeLocalAddresses #39387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

option: use netip.Prefix for DaemonConfig.ExcludeLocalAddresses #39387

merged 1 commit into from
May 8, 2025

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented May 7, 2025

Convert DaemonConfig.ExcludeLocalAddresses to []netip.Prefix which also simplifies (*DaemonConfig).IsExcludedLocalAddress and doesn't require the single caller to convert from netip.Addr to net.IP first.

For #24246

@tklauser tklauser requested a review from mhofstetter May 7, 2025 11:51
@tklauser tklauser requested review from a team as code owners May 7, 2025 11:51
@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels May 7, 2025
@tklauser
Copy link
Member Author

tklauser commented May 7, 2025

/test

@tklauser tklauser enabled auto-merge May 7, 2025 11:51
@tklauser tklauser force-pushed the pr/tklauser/host-addresses-netip branch from 1c78b09 to 2a502d8 Compare May 7, 2025 11:54
@tklauser
Copy link
Member Author

tklauser commented May 7, 2025

/test

@tklauser tklauser force-pushed the pr/tklauser/host-addresses-netip branch from 2a502d8 to c9c141c Compare May 7, 2025 13:04
@tklauser
Copy link
Member Author

tklauser commented May 7, 2025

/test

mhofstetter
mhofstetter approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tklauser
option: use netip.Prefix for DaemonConfig.ExcludeLocalAddresses
7fa2da8 
Convert DaemonConfig.ExcludeLocalAddresses to []netip.Prefix which also
simplifies (*DaemonConfig).IsExcludedLocalAddress and doesn't require
the single caller to convert from netip.Addr to net.IP first.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/tklauser/host-addresses-netip branch from c9c141c to 7fa2da8 Compare May 8, 2025 06:14
@tklauser
Copy link
Member Author

tklauser commented May 8, 2025

/test

@tklauser tklauser added this pull request to the merge queue May 8, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 8, 2025
Merged via the queue into main with commit bf67b0b May 8, 2025
332 of 334 checks passed
@tklauser tklauser deleted the pr/tklauser/host-addresses-netip branch May 8, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@mhofstetter mhofstetter mhofstetter approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tklauser @joestringer @mhofstetter