Skip to content

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented May 6, 2025

3790121 ("add securityContext for cronjob & disable hostNetwork") updated the hubble certgen job definition configuring a restrictive security context, and disabling host network. However, it missed updating the definition of the clustermesh one. Let's get that fixed, so that they are aligned.

Fixes: #issue-number

Add securityContext & disable hostNetwork in clustermesh-apiserver cronjob helm template

@giorio94 giorio94 added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/helm Impacts helm charts and user deployment experience labels May 6, 2025
@giorio94
Copy link
Member Author

giorio94 commented May 6, 2025

/test

Copy link

github-actions bot commented Jun 6, 2025

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jun 6, 2025
@jcpunk
Copy link
Contributor

jcpunk commented Jun 6, 2025

I'll confess interest in this.

@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jun 7, 2025
@giorio94
Copy link
Member Author

I'll confess interest in this.

Unfortunately this change uncovered an unrelated bug in Cilium (#39370). We need that to be fixed before getting this change in, otherwise CI becomes more flaky.

@joestringer joestringer added the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Jun 20, 2025
@joestringer joestringer removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Jul 1, 2025
Copy link

github-actions bot commented Aug 1, 2025

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 1, 2025
Copy link

This pull request has not seen any activity since it was marked stale.
Closing.

@github-actions github-actions bot closed this Aug 16, 2025
@giorio94 giorio94 reopened this Aug 18, 2025
@giorio94 giorio94 removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 18, 2025
3790121 ("add securityContext for cronjob & disable hostNetwork")
updated the hubble certgen job definition configuring a restrictive
security context, and disabling host network. However, it missed
updating the definition of the clustermesh one. Let's get that fixed,
so that they are aligned.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the mio/helm-uniform-certgen-clustermesh branch from 27a71af to 10f4ca4 Compare August 18, 2025 07:51
@giorio94
Copy link
Member Author

/test

@giorio94
Copy link
Member Author

Ready for review again, now that #39370 got fixed.

@giorio94 giorio94 marked this pull request as ready for review August 18, 2025 14:31
@giorio94 giorio94 requested review from a team as code owners August 18, 2025 14:31
@giorio94 giorio94 requested review from marseel and gandro August 18, 2025 14:31
@giorio94 giorio94 enabled auto-merge August 18, 2025 15:20
@giorio94 giorio94 added this pull request to the merge queue Aug 18, 2025
Merged via the queue into cilium:main with commit 734224c Aug 18, 2025
78 checks passed
@giorio94 giorio94 deleted the mio/helm-uniform-certgen-clustermesh branch August 18, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/helm Impacts helm charts and user deployment experience release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants