hubble: move AssertProtoEqual helper to hubble testutils #39366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the AssertProtoEqual test helper out of the test/helpers package which otherwise contains the test helpers for Ginkgo-based tests. The existing pkg/hubble/testutils package seems like a more appropriate place for the helper. Also this reduces initial test build time for pkg/hubble from ~28s to ~15s on my machine. Signed-off-by: Tobias Klauser <tobias@cilium.io>
|
/test |
christarazi
approved these changes
May 6, 2025
rolinh
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the
AssertProtoEqualtest helper out of thetest/helperspackage which otherwise contains the test helpers for Ginkgo-based tests. The existingpkg/hubble/testutilspackage seems like a more appropriate place for the helper. Also this reduces initial test build time forpkg/hubblefrom ~28s to ~15s on my machine.