cilium-cli: Migrate from corev1.Endpoints to discoveryv1.EndpointSlice
#39364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
|
Pinging @aanm because I think Cilium 1.18 still will K8s <1.33 where endpoints haven't been deprecated yet |
|
I think it should be fine as long as clusters are on kubernetes v1.21+ to have endpointslices, see example from a $ k version
Server Version: v1.31.6
$ k get endpoints
NAME ENDPOINTS AGE
cluster-autoscaler 10.131.54.22:8085,10.131.55.99:8085 112d
$ k get endpointslices
NAME ADDRESSTYPE PORTS ENDPOINTS AGE
cluster-autoscaler-nv2tz IPv4 8085 10.131.54.22,10.131.55.99 112d |
|
According to @aanm it is possible that users might still have endpoint slices disabled on 1.32 and older. Having said that, it's probably fine to merge this, as long as we mention it in the release notes. |
gandro
approved these changes
May 7, 2025
joamaki
approved these changes
May 9, 2025
tklauser
approved these changes
May 13, 2025
|
@HadrienPatte could you please rebase this PR branch? This should fix the failing GitHub Workflow Related Checks / Validate Workflow Names check. |
…lice` `corev1.Endpoints` is deprecated in v1.33+ `discoveryv1.EndpointSlice` is stable since v1.21 Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
f9a8083 to
0e36d25
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corev1.Endpointsis deprecated in v1.33+discoveryv1.EndpointSliceis stable since v1.21Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.