datapath/tables: use netip types where possible #39363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
76058b8 to
68e693f
Compare
|
/test |
Check whether the address is a link-local unicase address on the netip.Addr directly instead of converting it to a net.IP just for the check. Signed-off-by: Tobias Klauser <tobias@cilium.io>
This avoids having to convert each address in (*Device).Addrs to net.IP for comparison. Instead, the passed node IP needs to be converted to netip.Addr once (at least until node/types is converted to netip types as well). Signed-off-by: Tobias Klauser <tobias@cilium.io>
This is unused and netip.Addr types should be preferred. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Avoid having to convert to net.IP or string during tests. Consistently use netip.Addr instead. Signed-off-by: Tobias Klauser <tobias@cilium.io>
68e693f to
1273770
Compare
|
/test |
rgo3
approved these changes
May 7, 2025
YutaroHayakawa
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
For #24246