debuginfo: move debuginfo api handler from daemon to pkg/debug/api #39357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
234eb64 to
0640412
Compare
|
/test -> removing dependencies led to a slight rearrange of the agent initialization order which made a ratelimit map init race visible. This issue should be fixed with: #39361 |
0640412 to
2bf72dd
Compare
2bf72dd to
835ae86
Compare
|
/test |
This commit moves the debuginfo api handler from the daemon to a new Hive Cell in `pkg/debug/api`. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
There are no more Cilium API handlers that are served by the `Daemon`. Therefore, this commit removes `daemon/cmd/api_handlers.go` completely Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
835ae86 to
b1ec8f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the debuginfo api handler from the daemon to a new Hive Cell in
pkg/debug/api.As this was the last api handler that was implemented by the
Daemon, we can delete the apihandler "integration logic" completely from the daemon 🎉Potential follow up: Implement debuginfo registration mechanism with Hive Value Groups