hubble: use functional options pattern for SkipUnknownCGroupIDs #39355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
Like other for options in the Hubble subsystem, use the Go function options pattern to enable/disable skipping of events with unknown CGroup IDs (SkipUnknownCGroupIDs) instead of wiring through a bool. Signed-off-by: Tobias Klauser <tobias@cilium.io>
4ac426e to
7ac565e
Compare
|
/test |
kaworu
approved these changes
May 20, 2025
tklauser
added a commit
that referenced
this pull request
May 20, 2025
The Hubble parser options are already logged as part of the Hubble cell options. There is no point in logging the values again in each options.With* function. Ref. #39355 (comment) Suggested-by: Alexandre Perrin <alex@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
that referenced
this pull request
May 20, 2025
The Hubble parser options are already logged as part of the Hubble cell options. There is no point in logging the values again in each options.With* function. Ref. #39355 (comment) Suggested-by: Alexandre Perrin <alex@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
that referenced
this pull request
May 20, 2025
The Hubble parser options are already logged as part of the Hubble cell options. There is no point in logging the values again in each options.With* function. Ref. #39355 (comment) Suggested-by: Alexandre Perrin <alex@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 21, 2025
The Hubble parser options are already logged as part of the Hubble cell options. There is no point in logging the values again in each options.With* function. Ref. #39355 (comment) Suggested-by: Alexandre Perrin <alex@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like other for options in the Hubble subsystem, use the Go function options pattern to enable/disable skipping of events with unknown CGroup IDs (
SkipUnknownCGroupIDs) instead of wiring through abool.