Support triggering Makefiles from outside the tree #39344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be useful to run make files from other directories, for instance to build all binaries outside the source tree. As a step to support this, update direct paths in the Makefile to refer based on the path of the Makefile itself rather than the directory where make is executed. Signed-off-by: Joe Stringer <joe@cilium.io>
|
/test |
rolinh
approved these changes
May 9, 2025
derailed
approved these changes
May 9, 2025
sayboras
added a commit
that referenced
this pull request
Jul 1, 2025
Relates: #39344 Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
Relates: #39344 Signed-off-by: Tam Mach <tam.mach@cilium.io>
rabelmervin
pushed a commit
to rabelmervin/cilium
that referenced
this pull request
Aug 18, 2025
Relates: cilium#39344 Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to run make files from other directories, for instance
to build all binaries outside the source tree. As a step to support
this, update direct paths in the Makefile to refer based on the path of
the Makefile itself rather than the directory where make is executed.