Skip to content

Conversation

roman-kiselenko
Copy link
Contributor

These changes fix the wrong annotations generation.

Fixes: #39208

Cilium helm template preflight daemonset is broken.
These changes fix the wrong annotations generation.

@roman-kiselenko roman-kiselenko requested review from a team as code owners April 28, 2025 12:59
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 28, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Apr 28, 2025
@roman-kiselenko
Copy link
Contributor Author

@nathanjsweet @joestringer @Artyop PTAL

@aanm aanm enabled auto-merge April 29, 2025 09:15
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Apr 29, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 29, 2025
@aanm
Copy link
Member

aanm commented Apr 29, 2025

/test

@roman-kiselenko
Copy link
Contributor Author

I believe the failed tests are not related. 🤔

@squeed
Copy link
Contributor

squeed commented Apr 30, 2025

agreed, a retest should eventually get it in. You can re-run the specific failing job with the comment /ci-e2e-upgrade

@roman-kiselenko
Copy link
Contributor Author

/ci-e2e-upgrade

These changes fix the wrong annotations generation.

Signed-off-by: roman-kiselenko <roman.kiselenko.dev@gmail.com>
@aanm aanm force-pushed the preflight-install-helm branch from f9f8f80 to b86fe63 Compare May 8, 2025 09:22
@aanm
Copy link
Member

aanm commented May 8, 2025

/test

@aanm aanm added this pull request to the merge queue May 8, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 8, 2025
Merged via the queue into cilium:main with commit 809b23a May 8, 2025
66 checks passed
@roman-kiselenko roman-kiselenko deleted the preflight-install-helm branch May 13, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cilium-preflight/daemonset.yaml contains wrong formatting
4 participants