Skip to content

helm: PodDisruptionBudget takes additional keys in v1.27+ #39299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

helm: PodDisruptionBudget takes additional keys in v1.27+ #39299

merged 1 commit into from
May 16, 2025

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented May 2, 2025

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

PodDisruptionBudget takes an additional key of unhealthyPodEvictionPolicy. The chart is now smart enough to let folks set the keys in a free form manner

helm: PodDisruptionBudget can now set unhealthyPodEvictionPolicy

@jcpunk jcpunk requested review from a team as code owners May 2, 2025 20:55
@jcpunk jcpunk requested review from joamaki and kaworu May 2, 2025 20:55
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 2, 2025
@jcpunk jcpunk requested a review from giorio94 May 2, 2025 20:55
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 2, 2025
giorio94
giorio94 approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Approving, pending resolution of the inline comment.

@giorio94 giorio94 added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/helm Impacts helm charts and user deployment experience labels May 5, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 5, 2025
@jcpunk
Copy link
Contributor Author

jcpunk commented May 5, 2025

I have no idea how to fix the tests.

@giorio94
Copy link
Member

giorio94 commented May 5, 2025

I have no idea how to fix the tests.

Don't worry about them at the moment, the failure is definitely unrelated (most likely a rebase would help).

@aanm aanm enabled auto-merge May 8, 2025 09:25
@aanm
Copy link
Member

aanm commented May 8, 2025

/test

@gandro gandro disabled auto-merge May 8, 2025 09:40
@gandro
Copy link
Member

gandro commented May 8, 2025

Disabled auto-merge as there are ongoing discussions

@jcpunk jcpunk force-pushed the pdb-flex branch 2 times, most recently from 82ec247 to db18010 Compare May 12, 2025 20:37
giorio94
giorio94 approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@giorio94
Copy link
Member

/test

@giorio94 giorio94 enabled auto-merge May 13, 2025 07:19
@gandro
Copy link
Member

gandro commented May 13, 2025

Image build failed due to Quay.io throwing errors. Closing and re-opening PR to re-trigger.

@gandro gandro closed this May 13, 2025
@gandro gandro enabled auto-merge May 14, 2025 15:11
@gandro gandro added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit May 15, 2025
@gandro gandro added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit May 15, 2025
@gandro gandro removed the request for review from kaworu May 15, 2025 07:23
@sayboras sayboras added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit May 15, 2025
@gandro
Copy link
Member

gandro commented May 15, 2025 •
edited
Loading

Not entirely sure why GitHub rejects the merge. Let's try rebasing and re-running CI 🤷

@gandro
Copy link
Member

gandro commented May 15, 2025

Ah, it seems there's probably some kind of merge conflict - I can't automatically rebase:
image

@jcpunk Would you mind doing a manual rebase on main for this PR? Thanks and apologies for the inconvenience.

@jcpunk
Copy link
Contributor Author

jcpunk commented May 15, 2025

Rebased.

@Artyop
Copy link
Contributor

Artyop commented May 15, 2025

/test

@giorio94
Copy link
Member

It seems there's something wrong with the autogenerated helm documentation: https://github.com/cilium/cilium/actions/runs/15046595406/job/42290570850?pr=39299

@jcpunk Could you please re-run:

make -C Documentation update-helm-values

And commit the changes?

@jcpunk jcpunk requested a review from a team as a code owner May 15, 2025 19:32
@jcpunk jcpunk requested a review from qmonnet May 15, 2025 19:32
@jcpunk jcpunk force-pushed the pdb-flex branch 2 times, most recently from 6da1404 to 1bb63ad Compare May 15, 2025 19:36
@jcpunk
helm: PodDisruptionBudget takes additional keys in v1.27+
79f9748 
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
@jcpunk
Copy link
Contributor Author

jcpunk commented May 15, 2025

Rebased and re-ran doc update

@qmonnet
Copy link
Member

qmonnet commented May 16, 2025

/test

@giorio94 giorio94 enabled auto-merge May 16, 2025 10:38
@giorio94 giorio94 added this pull request to the merge queue May 16, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 16, 2025
Merged via the queue into cilium:main with commit 8ebee62 May 16, 2025
67 checks passed
@jcpunk jcpunk deleted the pdb-flex branch May 16, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@joamaki joamaki joamaki approved these changes

@qmonnet qmonnet qmonnet approved these changes

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jcpunk @giorio94 @aanm @gandro @Artyop @qmonnet @joamaki