bugtool: include human-readable ttl for ct entries #39293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` # sdiff -w 201 <(cilium bpf ct list global | head -1) <( cilium bpf ct list global --time-diff | head -1) TCP IN 10.104.4.1:48022 -> 10.104.4.3:19090 expires=16997807 Packets=10 Bytes=954 RxFlagsSeen=0x1 | TCP IN 10.104.4.1:48022 -> 10.104.4.3:19090 expires=16997807 (remaining: -9699 sec(s)) Packets=10 ``` Signed-off-by: Mark St John <markstjohn@google.com>
|
/test |
1 similar comment
|
/test |
mhofstetter
approved these changes
May 5, 2025
There was a problem hiding this comment.
Thanks for the change!
This looks good to me - even though changing the command also changes the filename in the sysdump (cilium-dbg-bpf-ct-list-global---time-diff.md - including the flag in the file)
Note: I prefixed the PR title & release note with bugtool: .
|
Is |
|
Did you consider also converting the |
|
I did not, thanks for the suggestion. I will take a look at that. |
|
I wasn't sure if you were going to look into the above in this PR, but the suggested change can be a different submission. I'll trigger the merge for this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
--time-diffoption for ct list commands provides improved readability for the conntrack entry lifetime.Example diff: