Skip to content

Remove remaining references to consul #39291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Conversation

joestringer
Copy link
Member

Cilium no longer supports Consul since commit f323ffc
("kvstore: Remove Consul support"), so there's no need to have
references to it in docs or code comments.

Cilium no longer supports Consul since commit f323ffc
("kvstore: Remove Consul support"), so there's no need to have
references to it in docs or code comments.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer requested a review from a team as a code owner May 1, 2025 23:49
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label May 1, 2025
@joestringer joestringer requested a review from a team as a code owner May 1, 2025 23:49
@joestringer joestringer requested review from giorio94 and qmonnet May 1, 2025 23:49
@joestringer
Copy link
Member Author

/test

@joestringer joestringer enabled auto-merge May 1, 2025 23:49
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joestringer joestringer added this pull request to the merge queue May 5, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 5, 2025
@giorio94 giorio94 added area/kvstore Impacts the KVStore package interactions. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels May 5, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 5, 2025
@julianwiedmann julianwiedmann added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit 0f47b63 May 5, 2025
333 of 334 checks passed
@julianwiedmann julianwiedmann deleted the pr/joe/consul-cleanup branch May 5, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kvstore Impacts the KVStore package interactions. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants