gateway-api: Fix parentRefMatched to check Group and Kind #39275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where the Gateway reconciler was not checking if the parentRef was a Gateway before checking if the name and namespace match. This caused GAMMA HTTPRoutes with a Service parentRef to be incorrectly attached to Gateways with the same name. Fixes: cilium#39193 Signed-off-by: Syed Azeez <syedazeez337@gmail.com>
e051884 to
83a775e
Compare
|
/test |
|
Hello reviewers, I have gone through the logs of the failed checks, It doesn't seem to be related to my code changes. Let me know what the issue could be. |
youngnick
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the Gateway reconciler was not checking if the parentRef was a Gateway before checking if the name and namespace match. This caused GAMMA HTTPRoutes with a Service parentRef to be incorrectly attached to Gateways with the same name.
The fix adds a check to ensure that the parentRef's Group and Kind match the Gateway API group and Gateway kind before proceeding with name and namespace matching.
How has this been tested?
Added a new test case to verify that a GAMMA Service with the same name as a Gateway is not matched by the Gateway reconciler. All existing tests continue to pass.
Fixes: #39193
Checklist