Fix node linux unit tests #39272
Merged
Fix node linux unit tests #39272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestAgentRestartOptionChanges was meant to verify the correct insertion and removal of the tunnel map entries following a change in the daemon config options (specifically the enabling and disabling of IP addresses families). Since the tunnel map has been removed and the routes handling is tested in the other linux node tests, TestAgentRestartOptionChanges can be safely removed. This fixes a previous incorrect change in the test that was undetected by the CI because the entire node_linux_test.go file was not built as part of the test suite due to the "unparallel" build tag. The fixes aimed to verify that the routes were updated after a node configuration change, but the linux node handler does not have (and never has been) that ability. Fixes: ef893ad ("node: Rework the agent restart test") Related: 91df013 ("pkg: Mark node_linux_test.go as unparallel") Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
The local node configuration should be set before inserting the fake routes, otherwise the route addition fails with the following error: The test failure went undetected in the CI because the entire node_linux_test.go file was not built as part of the test suite due to the "unparallel" build tag. Related: 91df013 ("pkg: Mark node_linux_test.go as unparallel") Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
|
/test |
gentoo-root
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node linux tests have been updated in #38490 to remove all the assertions regarding the deprecated tunnel map. However:
All of these should have led to the tests failing in the CI, but that didn't happen because of #38172: the
node_linux_test.gofile has been tagged asunparallelbut thetests-privilegedtarget in the Makefile has not been updated to include the wholenodepackage as part of theUNPARALLELTESTPKGSlist.The latter issue will be addressed in #39250, where a run of the updated tests completed successfully.