Skip to content

helm: permit resource limits for certgen cronjob #39261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

helm: permit resource limits for certgen cronjob #39261

merged 1 commit into from
May 12, 2025

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Apr 30, 2025

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.

Fixes: #issue-number

Helm: Add option to define resource limits for cerngen cronjob

@jcpunk jcpunk requested review from a team as code owners April 30, 2025 14:19
@jcpunk jcpunk requested review from youngnick and kaworu April 30, 2025 14:19
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 30, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Apr 30, 2025
@ldelossa
Copy link
Contributor

ldelossa commented May 1, 2025 •
edited
Loading

@jcpunk this PR is suffering from doc lint errors.

Please perform the suggestion in the broken test:
HINT: to fix this, run 'make -C Documentation update-helm-values'

And push the changes back up.

@ldelossa
Copy link
Contributor

ldelossa commented May 1, 2025

Helm charts are failing lints. Please perform the suggestion:

"Make sure to apply your changes to cilium/*values.yaml.tmpl and run 'make -C install/kubernetes cilium/values.yaml' to regenerate.";

And push the changes back up.

@jcpunk jcpunk force-pushed the cronjob-resource-limits branch from 8e5b210 to a349815 Compare May 1, 2025 16:05
@jcpunk
Copy link
Contributor Author

jcpunk commented May 1, 2025

Ran the doc updates and pushed just now.

@jcpunk jcpunk force-pushed the cronjob-resource-limits branch from a349815 to 4c593dd Compare May 1, 2025 16:10
gandro
gandro reviewed May 5, 2025
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There seems to be a minor chmod permission problem

@jcpunk jcpunk force-pushed the cronjob-resource-limits branch from 4c593dd to 8871869 Compare May 5, 2025 14:08
gandro
gandro approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gandro gandro added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. area/helm Impacts helm charts and user deployment experience labels May 5, 2025
@gandro
Copy link
Member

gandro commented May 5, 2025

/test

@giorio94 giorio94 added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label May 6, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 6, 2025
@jcpunk jcpunk force-pushed the cronjob-resource-limits branch from 8871869 to c484f7f Compare May 6, 2025 16:08
@jcpunk jcpunk requested a review from a team as a code owner May 6, 2025 16:08
@jcpunk jcpunk requested a review from giorio94 May 6, 2025 16:08
giorio94
giorio94 approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@giorio94
Copy link
Member

giorio94 commented May 6, 2025

/test

@giorio94 giorio94 enabled auto-merge May 6, 2025 16:24
@giorio94
Copy link
Member

giorio94 commented May 7, 2025

@jcpunk Could you please rebase this branch onto main? A couple of unrelated CI workflows look fairly unhappy, and a rebase should likely fix them.

auto-merge was automatically disabled May 7, 2025 15:34

Head branch was pushed to by a user without write access

@jcpunk jcpunk force-pushed the cronjob-resource-limits branch from c484f7f to ae3e7d8 Compare May 7, 2025 15:34
@jcpunk
Copy link
Contributor Author

jcpunk commented May 7, 2025

Rebased

@giorio94

This comment was marked as outdated.

Sign in to view
@jcpunk @aanm
helm: permit resource limits for certgen cronjob
46718b9 
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
@aanm aanm force-pushed the cronjob-resource-limits branch from ae3e7d8 to 46718b9 Compare May 8, 2025 09:22
@aanm
Copy link
Member

aanm commented May 8, 2025

/test

@aanm aanm enabled auto-merge May 8, 2025 09:22
@gandro
Copy link
Member

gandro commented May 12, 2025

/test

@gandro gandro removed the request for review from kaworu May 12, 2025 08:17
@aanm aanm added this pull request to the merge queue May 12, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 12, 2025
Merged via the queue into cilium:main with commit 81365e5 May 12, 2025
66 checks passed
@jcpunk jcpunk deleted the cronjob-resource-limits branch May 12, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@youngnick youngnick youngnick approved these changes

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jcpunk @ldelossa @gandro @giorio94 @aanm @youngnick