Fix unparallel tests packages list in Makefile #39250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci-runtime |
7a65beb to
ac2dde5
Compare
|
/ci-runtime |
ac2dde5 to
fa06f40
Compare
|
/ci-runtime |
fa06f40 to
c12053b
Compare
Filter out goroutines leaked by previous tests in
TestBackendNeighborSync.
Specifically, this is needed to avoid failures when this test is run
after the linuxNodeHandler.registerIpsecMetricOnce is called in all the
other node tests that run with EnableIPSec set to true.
Here is an example of such a failure:
backend_neighbors_test.go:51: found unexpected goroutines:
[Goroutine 265 in state sync.Cond.Wait, 1 minutes, with sync.runtime_notifyListWait on top of the stack:
sync.runtime_notifyListWait(0xc000249990, 0x22)
/root/sdk/go1.24.2/src/runtime/sema.go:597 +0x159
sync.(*Cond).Wait(0x3edc768?)
/root/sdk/go1.24.2/src/sync/cond.go:71 +0x85
github.com/cilium/cilium/pkg/promise.(*promise[...]).Await(0x3eb1e80, {0x3edc768, 0x68c3760})
/host/pkg/promise/promise.go:106 +0x12b
github.com/cilium/cilium/pkg/metrics.withRegistry.func1()
/host/pkg/metrics/metrics.go:1594 +0x39
created by github.com/cilium/cilium/pkg/metrics.withRegistry in goroutine 294
/host/pkg/metrics/metrics.go:1593 +0x9f
...
]
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Since node_linux_test.go in pkg/datapath/linux is now tagged as unparallel, we need to update the packages considered for unparallel tests in the Makefile, otherwise ci-conformance-runtime does not run the linux node tests. Fixes: 91df013 ("pkg: Mark node_linux_test.go as unparallel") Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
c12053b to
82a772d
Compare
gentoo-root
approved these changes
May 5, 2025
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/datapath/linux/node_linux_test.gohas been tagged asunparallelin #38172. Therefore, we need to update the packages list for the unparallel tests in the Makefile, otherwise thetests-privilegedtarget will skip the whole file:To fix this, the
UNPARALLELTESTPKGSvariable is updated to include the wholepkg/datapath/linuxpackage instead of the sole ipsec subpackage.See this run of
ci-runtimeagainst the main branch to verify that privileged tests innode_linux_test.goare not executed at all.After this change, ci-runtime is correctly picking up the priviliged tests in
node_linux_test.goagain, see this run.Also, the
TestBackendNeighborSynctest is updated to filter out goroutines leaked in previous tests, in order to avoid unrelated failures.Related: #38172
Waiting for #39272 to be merged first, in order to fix the linux node tests that are currently broken.