Skip to content

legacy/redirectpolicy: migrate to slog #39241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

legacy/redirectpolicy: migrate to slog #39241

merged 1 commit into from
May 15, 2025

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 29, 2025

Migrate this package to use slog instead of logrus.

@aanm aanm added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. area/lrp Impacts Local Redirect Policy. feature/slog labels Apr 29, 2025
@aanm
Copy link
Member Author

aanm commented Apr 29, 2025

/test

@aanm aanm marked this pull request as ready for review April 29, 2025 16:32
@aanm aanm requested a review from a team as a code owner April 29, 2025 16:32
@aanm aanm requested a review from aditighag April 29, 2025 16:32
@aanm aanm enabled auto-merge April 29, 2025 16:33
@aanm aanm added this pull request to the merge queue May 14, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2025
@julianwiedmann julianwiedmann added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2025
@julianwiedmann
Copy link
Member

julianwiedmann commented May 15, 2025 •
edited
Loading

Seems like this needs a fix-up to pass the build:

../pkg/loadbalancer/legacy/redirectpolicy/manager.go:143:45: undefined: logging

@julianwiedmann julianwiedmann removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 15, 2025
@aanm aanm added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2025
@aanm aanm force-pushed the pr/move-redirectpolicy-to-slog branch from a53dc1f to 22faabe Compare May 15, 2025 08:07
@aanm
Copy link
Member Author

aanm commented May 15, 2025

/test

@aanm aanm enabled auto-merge May 15, 2025 08:07
@aanm
legacy/redirectpolicy: migrate to slog
decbe0e 
Migrate this package to use slog instead of logrus.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/move-redirectpolicy-to-slog branch from 22faabe to decbe0e Compare May 15, 2025 09:30
@aanm
Copy link
Member Author

aanm commented May 15, 2025

/test

@aanm aanm added this pull request to the merge queue May 15, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2025
@aanm aanm added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit 87ecc88 May 15, 2025
304 of 308 checks passed
@aanm aanm deleted the pr/move-redirectpolicy-to-slog branch May 15, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditighag aditighag aditighag approved these changes

Assignees
No one assigned
Labels
area/lrp Impacts Local Redirect Policy. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. feature/slog ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aanm @julianwiedmann @aditighag