Skip to content

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 24, 2025

Move these packages to slog instead of logrus.

@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. feature/slog labels Apr 24, 2025
@aanm
Copy link
Member Author

aanm commented Apr 24, 2025

/test

@aanm aanm marked this pull request as ready for review April 24, 2025 09:44
@aanm aanm requested review from a team as code owners April 24, 2025 09:44
@aanm aanm enabled auto-merge April 24, 2025 10:11
@joestringer joestringer removed the request for review from youngnick April 24, 2025 19:28
@aanm aanm force-pushed the pr/move-launcher-eventqueue-to-slog branch from a3ab2a6 to 3b4e53c Compare April 25, 2025 07:47
@aanm
Copy link
Member Author

aanm commented Apr 25, 2025

/test

@aanm aanm requested a review from joestringer April 25, 2025 07:47
@aanm aanm force-pushed the pr/move-launcher-eventqueue-to-slog branch from 3b4e53c to 2bdc5f3 Compare April 25, 2025 07:55
@aanm
Copy link
Member Author

aanm commented Apr 25, 2025

/test

@aanm
Copy link
Member Author

aanm commented Apr 30, 2025

@jrajahalme can you PTAL?

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 8, 2025
Migrate this package to use slog instead of logrus.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/move-launcher-eventqueue-to-slog branch from 2bdc5f3 to f33dd5e Compare May 8, 2025 13:36
@maintainer-s-little-helper
Copy link

Commit f33dd5e does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 8, 2025
Migrate this package to use slog instead of logrus.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/move-launcher-eventqueue-to-slog branch from f33dd5e to 7585afc Compare May 8, 2025 13:37
@maintainer-s-little-helper
Copy link

Commit f33dd5e does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@aanm aanm removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 8, 2025
@aanm
Copy link
Member Author

aanm commented May 8, 2025

/test

@aanm aanm added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit e6d9710 May 8, 2025
363 of 374 checks passed
@aanm aanm deleted the pr/move-launcher-eventqueue-to-slog branch May 8, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/slog ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants