Skip to content

pkg/backoff: migrate to slog #39130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

pkg/backoff: migrate to slog #39130

merged 1 commit into from
May 20, 2025

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 24, 2025

Migrate this package to use slog instead of logrus.

@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. feature/slog labels Apr 24, 2025
@aanm
Copy link
Member Author

aanm commented Apr 24, 2025

/test

@aanm aanm force-pushed the pr/move-backoff-to-slog branch from 7c98def to c0d5db2 Compare April 24, 2025 09:47
@aanm
Copy link
Member Author

aanm commented Apr 24, 2025

/test

@aanm aanm marked this pull request as ready for review April 24, 2025 11:08
@aanm aanm requested review from a team as code owners April 24, 2025 11:08
@aanm aanm added dont-merge/bad-bot To prevent MLH from marking ready-to-merge. and removed dont-merge/bad-bot To prevent MLH from marking ready-to-merge. labels Apr 24, 2025
@aanm aanm enabled auto-merge April 24, 2025 11:35
pippolo84
pippolo84 approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for my codeowner, thanks!

@aanm
pkg/backoff: migrate to slog
db23e95 
Migrate this package to use slog instead of logrus.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/move-backoff-to-slog branch from c0d5db2 to db23e95 Compare April 29, 2025 15:19
@aanm
Copy link
Member Author

aanm commented Apr 29, 2025

/test

1 similar comment
@aanm
Copy link
Member Author

aanm commented Apr 30, 2025

/test

@aanm
Copy link
Member Author

aanm commented Apr 30, 2025

@jrajahalme @kaworu @aditighag can you PTAL?

@aanm aanm added this pull request to the merge queue May 20, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 20, 2025
Merged via the queue into main with commit 3e08adb May 20, 2025
336 of 338 checks passed
@aanm aanm deleted the pr/move-backoff-to-slog branch May 20, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@pippolo84 pippolo84 pippolo84 approved these changes

@marseel marseel marseel approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

@aditighag aditighag aditighag approved these changes

@smagnani96 smagnani96 smagnani96 approved these changes

+1 more reviewer

@doniacld doniacld doniacld approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
feature/slog ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aanm @kaworu @pippolo84 @marseel @jrajahalme @doniacld @aditighag @smagnani96