cec: fix missing call to injectCiliumEnvoyFilters #39127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR cilium#37868 introduced the possibility to control Cilium Envoy filter injection via annotation. But the PR missed one occurrence that is still only checking for `len(spec.Services) > 0` instead of calling `injectCiliumEnvoyFilters`. This commit fixes this. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
696efad to
83fdd3b
Compare
|
/test |
jrajahalme
approved these changes
May 5, 2025
|
@mhofstetter I was going to press the button, but then noticed the failing workflow. Do you think it's related to this PR? |
Thanks! No shouldn't be related to this change - but I re-ran the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #37868 introduced the possibility to control Cilium Envoy filter injection via annotation.
But the PR missed one occurrence that is still only checking for
len(spec.Services) > 0instead of callinginjectCiliumEnvoyFilters.This commit fixes this.