operator/pkg/gateway-api: Update ServiceImport and TLSRoute support c… #39122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hecks -Currently, if we dont have TLSRoute CRD installed, the operator will still try to list TLSRoute CRD that's because we validate the TLSRoute through IsGroupRegistered. - This commit refactors the HasServiceImportSupport and HasTLSRouteSupport functions to check for the registration of the ServiceImport and TLSRoute CRDs instead of IsGroupRegistered. so the optinal CRD will not just pass when the Group is registered. - Update the UT to test the TLSRoute properly Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
|
/test |
6 tasks
youngnick
approved these changes
Apr 24, 2025
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we dont have TLSRoute CRD installed, the operator will still try to list TLSRoute CRD that's because we validate the TLSRoute through IsGroupRegistered.
This commit refactors the HasServiceImportSupport and HasTLSRouteSupport functions to check for the registration of the ServiceImport and TLSRoute CRDs instead of IsGroupRegistered. so the optinal CRD will not just pass when the Group is registered.
Update the UT to test the TLSRoute properly
Fixes: #38420