Skip to content

Scalability testing docs #39171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Apr 25, 2025

Let's start scalability testing documentation and also make it possible to run ClusterLoader2 easily in kind.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 25, 2025
@marseel marseel changed the title Pr/marseel/scalability docs Scalability testing docs Apr 25, 2025
@marseel marseel force-pushed the pr/marseel/scalability_docs branch 2 times, most recently from ff7b1f2 to 202f3cd Compare May 13, 2025 13:48
@marseel marseel added the release-note/misc This PR makes changes that have no direct user impact. label May 13, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 13, 2025
@marseel marseel force-pushed the pr/marseel/scalability_docs branch from 202f3cd to a20a4ea Compare May 13, 2025 13:52
@marseel marseel requested review from hemanthmalla and jshr-w May 13, 2025 13:52
@marseel
Copy link
Contributor Author

marseel commented May 13, 2025

/test

@marseel marseel force-pushed the pr/marseel/scalability_docs branch from a20a4ea to 1f5f937 Compare May 14, 2025 11:04
@marseel
Copy link
Contributor Author

marseel commented May 14, 2025

/test

@marseel marseel force-pushed the pr/marseel/scalability_docs branch 2 times, most recently from c5d8b4c to 12e7bec Compare May 14, 2025 15:41
@marseel
Copy link
Contributor Author

marseel commented May 14, 2025

/test

@marseel marseel marked this pull request as ready for review May 15, 2025 10:48
@marseel marseel requested review from a team as code owners May 15, 2025 10:48
@marseel marseel requested a review from qmonnet May 15, 2025 10:48
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice doc!

Please find some grammar/formatting suggestions below.

My main concern is the usage of link to non-persistent test results (see near the end of the review, below).

@marseel marseel force-pushed the pr/marseel/scalability_docs branch from 12e7bec to a6d14b3 Compare May 15, 2025 13:12
@marseel
Copy link
Contributor Author

marseel commented May 15, 2025

Thanks @qmonnet for amazing review, I've definitely learned a few tricks :)

diff: https://github.com/cilium/cilium/compare/12e7bec60fce24a6f7d8244e2ac511a872fe7131..a6d14b3bd48f2d0e5f40ac3f4d71e12e8f7012d8

I went one more time through docs and fixed a couple of similar typos.

@marseel marseel requested a review from qmonnet May 15, 2025 13:14
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thank you!

@qmonnet
Copy link
Member

qmonnet commented May 15, 2025

/test

marseel added 2 commits May 19, 2025 17:08
Enable agent prometheus metrics and pprof for local development.
This allows for running scale test scenario locally as we are scraping
agent metrics + profiling information.
Additionally, expose /metrics endpoint in KCM and KS, as it is scrapped
by CL2 automatically for kind environments.

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
Introduce ClusterLoader2, example scale-tests that we currently have,
document current example use-cases. On top of that add documentation for
local development of scale tests, how to access results in CI and how to
debug scale test results.

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the pr/marseel/scalability_docs branch from a6d14b3 to f1dcc22 Compare May 19, 2025 15:08
@marseel
Copy link
Contributor Author

marseel commented May 19, 2025

/test

@marseel
Copy link
Contributor Author

marseel commented May 19, 2025

Rebased as "Conformance Multi Pool IPAM" was failing consistently :/

@marseel
Copy link
Contributor Author

marseel commented May 20, 2025

/test

@marseel
Copy link
Contributor Author

marseel commented May 27, 2025

Friendly ping @hemanthmalla @jshr-w :)

Copy link
Contributor

@jshr-w jshr-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, this looks really awesome :) I didn't realize we collect profiling data from the scale tests this way, that's helpful to know for the future.

@marseel marseel removed the request for review from hemanthmalla May 28, 2025 08:15
@giorio94 giorio94 added this pull request to the merge queue May 28, 2025
Merged via the queue into cilium:main with commit 2c0e0a3 May 28, 2025
79 of 98 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants