Skip to content

Move other various packages to slog #39165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

Move other various packages to slog #39165

merged 2 commits into from
May 15, 2025

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 25, 2025

No description provided.

@aanm aanm added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. feature/slog labels Apr 25, 2025
@aanm
Copy link
Member Author

aanm commented Apr 25, 2025

/test

@aanm aanm marked this pull request as ready for review April 25, 2025 11:15
@aanm aanm requested review from a team as code owners April 25, 2025 11:15
@aanm aanm enabled auto-merge April 25, 2025 11:15
@aanm aanm force-pushed the pr/move-misc-packages-2-to-slog branch from 5b8852b to 9e33b3f Compare April 28, 2025 10:21
@aanm
Copy link
Member Author

aanm commented Apr 28, 2025

/test

@aanm aanm force-pushed the pr/move-misc-packages-2-to-slog branch from 9e33b3f to dd2b1a2 Compare April 30, 2025 12:07
@aanm
Copy link
Member Author

aanm commented Apr 30, 2025

/test

@aanm aanm force-pushed the pr/move-misc-packages-2-to-slog branch from dd2b1a2 to 7d6dd9a Compare May 2, 2025 09:24
@aanm
Copy link
Member Author

aanm commented May 2, 2025

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 14, 2025
@julianwiedmann julianwiedmann added dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels May 15, 2025
@aanm aanm removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label May 15, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 15, 2025
aanm added 2 commits May 15, 2025 11:31
@aanm
pkg/l2announcer: migrate to slog
667ad30 
Migrate this package to use slog instead of logrus.

Signed-off-by: André Martins <andre@cilium.io>
@aanm
pkg/loadbalancer/benchmark/cmd: migrate to slog
fbb9dd6 
Migrate this package to use slog instead of logrus.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/move-misc-packages-2-to-slog branch from 7d6dd9a to fbb9dd6 Compare May 15, 2025 09:31
@aanm
Copy link
Member Author

aanm commented May 15, 2025

/test

@aanm aanm added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit 7bacee0 May 15, 2025
278 of 279 checks passed
@aanm aanm deleted the pr/move-misc-packages-2-to-slog branch May 15, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

@ldelossa ldelossa ldelossa approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

@youngnick youngnick youngnick approved these changes

@aditighag aditighag aditighag approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. feature/slog ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aanm @derailed @ldelossa @jrajahalme @youngnick @aditighag @julianwiedmann