cli: encryption: improve ICMPv6 NA detection #39160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break the long filter strings down into smaller pieces that are more composable. No change in behavior. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Make sure that we only process ICMPv6 packets in this filter. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Cilium's Wireguard logic doesn't encrypt NA messages. We currently ignore such ICMPv6 packets when in overlay routing mode. Do the same in native routing mode. Note that this filter actually seems redundant for the overlay case in encryption_v2 - the `baseTunnelFilter` already filters for UDP packets, so we shouldn't even see any ICMPv6 packets. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
|
/test |
|
@tommyp1ckles I think this is fairly straight-forward, but maybe you have any thoughts. Otherwise please just drop the label :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also plug the ICMPv6 NA filtering from #38798 into the native-routing paths, so that we avoid false-positives like this one in CI.