Skip to content

cli: De-duplicate workflow owners results in junit #39157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

cli: De-duplicate workflow owners results in junit #39157

merged 1 commit into from
Apr 25, 2025

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Apr 25, 2025 •
edited
Loading

Collect is called for each test, so the same workflow owners could be
collected from different tests multiple times. Avoid this by adding them
once during the junit collector creation.

@joestringer joestringer requested a review from a team as a code owner April 25, 2025 03:15
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Apr 25, 2025
@joestringer joestringer requested a review from Artyop April 25, 2025 03:15
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Apr 25, 2025
@joestringer
Copy link
Member Author

/test

@joestringer joestringer enabled auto-merge April 25, 2025 03:16
@joestringer joestringer force-pushed the pr/joe/cli-junit-fixes branch from 3dbecf4 to 504b9c8 Compare April 25, 2025 03:34
@joestringer
cli: De-duplicate workflow owners results in junit
1ec5738 
Collect is called for each test, so the same workflow owners could be
collected from different tests multiple times. Avoid this by adding them
once during the junit collector creation.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer force-pushed the pr/joe/cli-junit-fixes branch from 504b9c8 to 1ec5738 Compare April 25, 2025 03:34
@joestringer
Copy link
Member Author

/test

Artyop
Artyop approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@Artyop Artyop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joestringer joestringer added this pull request to the merge queue Apr 25, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 25, 2025
Merged via the queue into main with commit f906eab Apr 25, 2025
257 of 259 checks passed
@joestringer joestringer deleted the pr/joe/cli-junit-fixes branch April 25, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artyop Artyop Artyop approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joestringer @Artyop