Skip to content

Move node to slog #39147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Move node to slog #39147

merged 1 commit into from
May 14, 2025

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 24, 2025

No description provided.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 24, 2025
@github-actions github-actions bot added sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. cilium-cli This PR contains changes related with cilium-cli labels Apr 24, 2025
@aanm aanm changed the base branch from pr/move-endpoint-to-slog to main April 24, 2025 14:04
@aanm
Copy link
Member Author

aanm commented Apr 24, 2025

/test

@aanm aanm force-pushed the pr/move-node-to-slog branch from cc90639 to 6c14484 Compare April 24, 2025 14:04
@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. feature/slog labels Apr 24, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 24, 2025
@aanm
Copy link
Member Author

aanm commented Apr 24, 2025

/test

@aanm aanm force-pushed the pr/move-node-to-slog branch 3 times, most recently from b13ae44 to 0474b73 Compare April 24, 2025 15:28
@aanm
Copy link
Member Author

aanm commented Apr 24, 2025

/test

@aanm aanm force-pushed the pr/move-node-to-slog branch from 0474b73 to d2502e6 Compare April 25, 2025 07:48
@aanm
Copy link
Member Author

aanm commented Apr 25, 2025

/test

@aanm aanm marked this pull request as ready for review April 25, 2025 07:48
@aanm aanm requested review from a team as code owners April 25, 2025 07:48
@aanm aanm requested a review from ysksuzuki April 25, 2025 07:48
@aanm aanm enabled auto-merge April 25, 2025 07:49
sayboras
sayboras approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for proxy package

@aanm
Copy link
Member Author

aanm commented Apr 28, 2025

/test

@aanm aanm force-pushed the pr/move-node-to-slog branch from d2502e6 to 2388516 Compare April 28, 2025 10:22
@aanm
Copy link
Member Author

aanm commented Apr 29, 2025

/test

@aanm aanm force-pushed the pr/move-node-to-slog branch from 2388516 to 8493cbd Compare April 29, 2025 15:16
@aanm
Copy link
Member Author

aanm commented Apr 29, 2025

/test

@aanm aanm force-pushed the pr/move-node-to-slog branch from 8493cbd to 84f419f Compare April 30, 2025 11:56
@aanm
Copy link
Member Author

aanm commented Apr 30, 2025

/test

@aanm
Copy link
Member Author

aanm commented Apr 30, 2025

@ysksuzuki @pchaigno @jrajahalme @youngnick can you PTAL?

@aanm
pkg/node: migrate to slog
85291a5 
Migrate this package to use slog instead of logrus.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/move-node-to-slog branch from 84f419f to 85291a5 Compare May 9, 2025 14:06
@aanm
Copy link
Member Author

aanm commented May 9, 2025

/test

pchaigno
pchaigno approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but I'm really not convinced this sort of change requires 7 reviews. We need to fix something in our review process.

@aanm aanm added this pull request to the merge queue May 14, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 14, 2025
Merged via the queue into main with commit ef7d836 May 14, 2025
330 of 336 checks passed
@aanm aanm deleted the pr/move-node-to-slog branch May 14, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

@pchaigno pchaigno pchaigno approved these changes

@ysksuzuki ysksuzuki ysksuzuki approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

@sayboras sayboras sayboras approved these changes

@youngnick youngnick youngnick approved these changes

+1 more reviewer

@doniacld doniacld doniacld approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli feature/slog ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aanm @derailed @pchaigno @ysksuzuki @jrajahalme @sayboras @youngnick @doniacld