Skip to content

pkg/identity: migrate to slog #39145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

pkg/identity: migrate to slog #39145

merged 1 commit into from
May 8, 2025

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 24, 2025

Migrate this package to use slog instead of logrus.

@aanm aanm added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. feature/slog labels Apr 24, 2025
@github-actions github-actions bot added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label Apr 24, 2025
@aanm
Copy link
Member Author

aanm commented Apr 24, 2025

/test

@aanm aanm force-pushed the pr/move-pkg-identity-to-slog branch from 0739e16 to eb3b87c Compare April 25, 2025 07:51
@aanm
Copy link
Member Author

aanm commented Apr 25, 2025

/test

@aanm aanm marked this pull request as ready for review April 25, 2025 07:51
@aanm aanm requested review from a team as code owners April 25, 2025 07:51
@aanm aanm force-pushed the pr/move-pkg-identity-to-slog branch from eb3b87c to f45fa57 Compare April 25, 2025 07:52
@aanm aanm enabled auto-merge April 25, 2025 07:52
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli ✔️

@aanm
Copy link
Member Author

aanm commented Apr 25, 2025

/test

@aanm aanm force-pushed the pr/move-pkg-identity-to-slog branch 2 times, most recently from 3bbd6ab to 27d74ea Compare April 28, 2025 07:31
@aanm
Copy link
Member Author

aanm commented Apr 28, 2025

/test

@aanm aanm force-pushed the pr/move-pkg-identity-to-slog branch from 27d74ea to acc4e83 Compare April 28, 2025 08:26
@aanm
Copy link
Member Author

aanm commented Apr 28, 2025

/test

1 similar comment
@aanm
Copy link
Member Author

aanm commented Apr 28, 2025

/test

@aanm
Copy link
Member Author

aanm commented Apr 30, 2025

@jrajahalme can you PTAL?

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 8, 2025
@aanm aanm force-pushed the pr/move-pkg-identity-to-slog branch from acc4e83 to 8c12da5 Compare May 8, 2025 13:28
Migrate this package to use slog instead of logrus.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/move-pkg-identity-to-slog branch from 8c12da5 to 893c59c Compare May 8, 2025 13:30
@aanm
Copy link
Member Author

aanm commented May 8, 2025

/test

@aanm aanm added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit 268c77b May 8, 2025
304 of 310 checks passed
@aanm aanm deleted the pr/move-pkg-identity-to-slog branch May 8, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. feature/slog ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants