cilium-dbg: don't emit logs on flush #39018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
This was breaking CI as that wasn't emitting the expected output when running commands such as: ``` root@kind-worker:/home/cilium# cilium bpf ct flush global Flushed 61 entries from /sys/fs/bpf/tc/globals/cilium_ct4_global Flushed 6 entries from /sys/fs/bpf/tc/globals/cilium_ct_any4_global Flushed 4 entries from /sys/fs/bpf/tc/globals/cilium_ct6_global Flushed 6 entries from /sys/fs/bpf/tc/globals/cilium_ct_any6_global ``` This behavior was added in 694213c to add visibility following the decision to not emit error logs when we had a gc map delete "miss". Fixes: cilium#38989 Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
699642f to
f971b64
Compare
|
/test |
YutaroHayakawa
approved these changes
Apr 18, 2025
joestringer
reviewed
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was breaking CI as that wasn't emitting the expected output when running commands such as:
This behavior was added in 694213c to add visibility following the decision to not emit error logs when we had a gc map delete "miss".
Fixes: #38989