ciliumenvoyconfig: Unexperimentalize the new implementation #39086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa2dd78 to
591173a
Compare
mhofstetter
approved these changes
Apr 22, 2025
591173a to
7590c97
Compare
Yeeep, looks like I forgot to provide the PortAllocator. Fixed. |
7590c97 to
c8c6505
Compare
|
/test |
Make the resource parser available other packages. This will be used by the legacy implementation which the next commit moves into another package. Move the test cases associated with the CECResourceParser to its test suite.:w : Signed-off-by: Jussi Maki <jussi@isovalent.com>
Move the config struct to its own file and export for use in the legacy cell. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Move the old implementation to pkg/ciliumenvoyconfig/legacy to make it clear it is not used by default. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Drop the spec type from AddCEC etc. calls as that's not available for DelCEC. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Remove the exp_ prefixes. Remove mention of experimental. Rename CECMetrics to FeatureMetrics to avoid confusion. Signed-off-by: Jussi Maki <jussi@isovalent.com>
c8c6505 to
608b887
Compare
|
/test |
aanm
approved these changes
Apr 24, 2025
dylandreimerink
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the old implementation to pkg/ciliumenvoyconfig/legacy and rename the files. This makes it easy to remove the old implementation in few weeks once we're happy with the new implementation and avoids confusion during this period.
As part of this I noticed that the feature metrics were not implemented for the new implementation so added that too.