treewide: Remove /service REST API put and delete support #39084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d235e2 to
2726683
Compare
|
/test |
2726683 to
c64b8f9
Compare
|
/test |
Artyop
approved these changes
Apr 25, 2025
15 tasks
|
ping @nathanjsweet |
nathanjsweet
approved these changes
Apr 30, 2025
The new load-balancing implementation will not support the ID-based service updating and deleting as implemented by the REST API. This API had been available as part of the standalone Cilium load-balancer (datapath-mode=lb-only) which has been removed in this release, so remove the now unused API definitions and implementation. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Remove the code using "cilium-dbg service update" or "cilium-dbg service delete". Remove the "IPv6 Masquerading" test as that has not been run in CI for a long time and used the "cilium-dbg service update" which is no longer available. Signed-off-by: Jussi Maki <jussi@isovalent.com>
c64b8f9 to
f393370
Compare
brb
approved these changes
Apr 30, 2025
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new load-balancing implementation will not support the ID-based service updating and deleting as implemented by the REST API.
This API had been available as part of the standalone Cilium load-balancer (datapath-mode=lb-only) which has been removed in this release, so remove the now unused API definitions and implementation.
The removed "IPv6 Masquerading" ginkgo tests also has not been ran in a long time, so removing it as it relies on "cilium-dbg service update".