Envoy: ignore explicit listener rules on other listeners #39079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce17f00 to
47616f5
Compare
|
/test |
47616f5 to
7c70ac2
Compare
|
rebased to fix missing junit file problem. |
|
/test |
|
@jrajahalme i saw that you added the label |
7c70ac2 to
9366f53
Compare
|
fixed daemon tests |
a423206 to
91a232e
Compare
|
/test |
91a232e to
2b38c04
Compare
marseel
approved these changes
May 13, 2025
2b38c04 to
412babe
Compare
|
/test |
412babe to
3633186
Compare
mhofstetter
approved these changes
May 14, 2025
|
/test |
christarazi
approved these changes
May 14, 2025
rolinh
approved these changes
May 16, 2025
3633186 to
757b9ae
Compare
|
/test |
squeed
approved these changes
May 26, 2025
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Pass the proxy port of an explicit Listener reference in CNP as a proxy ID and ignore rules with non-zero proxy IDs unless the proxy ID matches the one configured for the Listener handling the connection. This scopes the policy rule containing the explicit Listener reference to only apply on the specific named listener. This way possibly stricter allow rules specified otherwise will not be bypassed due to the laxer allow rule for the specific listener. Disable HTTP rule short-circuiting also when a rule has a non-zero proxy-id. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
757b9ae to
b583a70
Compare
|
rebased, API update was already done on main |
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the proxy port of an explicit Listener reference in CNP as a proxy ID and ignore rules with non-zero proxy IDs unless the proxy ID matches the one configured for the Listener handling the connection. This scopes the policy rule containing the explicit Listener reference to only apply on the specific named listener. This way possibly stricter allow rules specified otherwise will not be bypassed due to the laxer allow rule for the specific listener.