cli: Emit target package for error in logs failure #38986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christarazi
approved these changes
Apr 16, 2025
marseel
reviewed
Apr 17, 2025
In a case like in the "no-errors-in-logs" test case, the use of a '/' to split the scenario vs action name made the different fields ambiguous. Fix it by replacing it with a colon. Before: . [.] Action [check-log-errors/no-errors-in-logs/kind-kind/kube-system/cilium-znv6v (cilium-agent)] After: . [.] Action [check-log-errors/no-errors-in-logs:kind-kind/kube-system/cilium-znv6v (cilium-agent)] Signed-off-by: Joe Stringer <joe@cilium.io>
When the "no-errors-in-logs" test fails, report the package with the
error as part of the action name so that it's easier for developers to
understand which area of the codebase is emitting the error log.
Example test output:
...
. [.] Action [check-log-errors/no-errors-in-logs:vendor/github.com/cilium/hive/job:kind-kind/kube-system/cilium-znv6v (install-cni-binaries)]
.
📋 Test Report [cilium-test-1]
❌ 1/1 tests failed (4/17 actions), 118 tests skipped, 0 scenarios skipped:
Test [check-log-errors]:
❌ check-log-errors/no-errors-in-logs:vendor/github.com/cilium/hive/job:kind-kind/kube-system/cilium-d6vf2 (cilium-agent)
⛑️ The following owners are responsible for reliability of the testsuite:
- @cilium/vendor (no-errors-in-logs:vendor/github.com/cilium/hive/job)
Signed-off-by: Joe Stringer <joe@cilium.io>
acfbd2c to
91aeb5e
Compare
|
/test |
YutaroHayakawa
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "no-errors-in-logs" test fails, report the package with the
error as part of the action name so that it's easier for developers to
understand which area of the codebase is emitting the error log.
Example test output: