Skip to content

connectivity/check: fix logging error #38956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

connectivity/check: fix logging error #38956

merged 1 commit into from
Apr 16, 2025

Conversation

mhofstetter
Copy link
Member

This commit fixes the logoutput for some log messages that log errors without using the formatting version (ct.Fail -> ct.Failf).

e.g.

🟥 failed to flush ct entries: %w command failed (pod=kube-system/cilium-rwnk8, container=cilium-agent): "time=\"2025-04-15T11:01:18.020032526Z\" level=info msg=\"completed ctmap gc pass\" aliveEntries=0 deleted=5 family=ipv4 proto=TCP skipped=0 subsys=map-ct\ntime=\"2025-04-15T11:01:18.020619446Z\" level=info msg=\"completed ctmap gc pass\" aliveEntries=0 deleted=4 family=ipv4 proto=non-TCP skipped=0 subsys=map-ct\n"

@mhofstetter
connectivity/check: fix logging error
a0a32e4 
This commit fixes the logoutput for some log messages that log
errors without using the formatting version (`ct.Fail` -> `ct.Failf`).

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter added area/cli Impacts the command line interface of any command in the repository. release-note/misc This PR makes changes that have no direct user impact. labels Apr 15, 2025
@mhofstetter mhofstetter requested a review from a team as a code owner April 15, 2025 11:40
@mhofstetter mhofstetter requested a review from christarazi April 15, 2025 11:40
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Apr 15, 2025
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter removed the request for review from christarazi April 16, 2025 09:31
@mhofstetter mhofstetter added dont-merge/blocked Another PR must be merged before this one. and removed dont-merge/blocked Another PR must be merged before this one. labels Apr 16, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 16, 2025
@sayboras sayboras added this pull request to the merge queue Apr 16, 2025
Merged via the queue into cilium:main with commit c716ab6 Apr 16, 2025
72 of 73 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/cli-checkcontext-fatalf branch April 16, 2025 10:10
@aditighag aditighag mentioned this pull request Apr 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
area/cli Impacts the command line interface of any command in the repository. cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhofstetter @pchaigno @sayboras