Skip to content

datapath/tables: use netip.Prefix instead of *cidr.CIDR #38951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

datapath/tables: use netip.Prefix instead of *cidr.CIDR #38951

merged 1 commit into from
Apr 15, 2025

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Apr 15, 2025 •
edited
Loading

This simplifies code and avoids conversion of existing netip.Addr to net.IP for comparison.

For #24246

@tklauser
datapath/tables: use netip.Prefix instead of *cidr.CIDR
75ef8ef 
This simplifies code and avoids conversion of existing netip.Addr to
net.IP for comparison.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Apr 15, 2025
@tklauser tklauser requested review from a team as code owners April 15, 2025 09:04
@tklauser
Copy link
Member Author

/test

@tklauser tklauser enabled auto-merge April 15, 2025 09:04
@tklauser tklauser mentioned this pull request Apr 15, 2025
Merged
1 task
@tklauser tklauser changed the title datapath/tables: use netip.Prefix instead of *cidr.CIDR datapath/tables: use netip.Prefix instead of *cidr.CIDR Apr 15, 2025
@tklauser tklauser added this pull request to the merge queue Apr 15, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 15, 2025
Merged via the queue into main with commit 16f88e4 Apr 15, 2025
304 checks passed
@tklauser tklauser deleted the pr/tklauser/node-port-addresses-netip-prefix branch April 15, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandreimerink dylandreimerink dylandreimerink approved these changes

+1 more reviewer

@doniacld doniacld doniacld approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tklauser @dylandreimerink @doniacld