Assign codeowners for no-errors-in-logs testcase #38812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5abeeb8 to
ebd50a7
Compare
|
/test |
joestringer
approved these changes
Apr 9, 2025
There was a problem hiding this comment.
Seems like a reasonable way to do this. Hopefully we don't have a flood of many failure logs, but even if we do it makes sense to start with the most common failures anyway.
Main note is about how reliable the slog extension is and also if we could do better for stable branches. Might even be worth splitting the cilium-agent changes into a separate dedicated PR just to simplify backporting, but that's not a big deal.
brlbil
approved these changes
Apr 10, 2025
Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
Before, we were counting unique logs also taking into account timestamp. As a result, almost all errors were unique so it didn't give a good signal of which error is most common. Let's switch to counting unique errors only based on msg field instead. Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
For cases when log is produced by slog and debug logs are enabled, we have an additional path with location of source file. In case of no-errors-in-logs failure, we can attribute failure to CODEOWNERS of that file which generated error log. This will be especially useful for CI. Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
73ffea5 to
96496ea
Compare
|
/test |
joestringer
approved these changes
Apr 10, 2025
|
@derailed Friendly ping :) |
derailed
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To show how aggregation and reporting works, I've switched one log "Updating tunnel map entry" from Debug to Error.
Example run: https://github.com/cilium/cilium/actions/runs/14337153953/job/40187065813?pr=38812
Notice that
occurrencesare calculated better now, before because of timestamps we were not aggregating them together.Error is reported for datapath team, who is owner of file (
pkg/datapath/linux/node.go) containing this log message: