Skip to content

connectivity: Correct version check for Ingress test #38803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

connectivity: Correct version check for Ingress test #38803

merged 1 commit into from
Apr 8, 2025

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Apr 8, 2025

The conditions should be including per minor version with OR operation. Otherwise, the test will be skipped like below

Skipping test [pod-to-ingress-service-deny-source-egress-other-node] [20/22] (requires Cilium version >1.17.1 >1.16.7 >1.15.14 but running 1.16.8)

Fixes: 212c228
Relates: #38053 (comment)

Reported-by: Julian Wiedmann jwi@isovalent.com
Suggested-by: Simone Magnani simone.magnani@isovalent.com

@sayboras
connectivity: Correct version check for Ingress test
c47c712 
The conditions should be including per minor version with OR operation.
Otherwise, the test will be skipped like below

```
Skipping test [pod-to-ingress-service-deny-source-egress-other-node] [20/22] (requires Cilium version >1.17.1 >1.16.7 >1.15.14 but running 1.16.8)
```

Fixes: 212c228
Reported-by: Julian Wiedmann <jwi@isovalent.com>
Suggested-by: Simone Magnani <simone.magnani@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 8, 2025
@sayboras sayboras added the release-note/ci This PR makes changes to the CI. label Apr 8, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 8, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Apr 8, 2025
@sayboras sayboras marked this pull request as ready for review April 8, 2025 10:23
@sayboras sayboras requested a review from a team as a code owner April 8, 2025 10:23
@sayboras sayboras requested a review from brlbil April 8, 2025 10:23
@sayboras sayboras mentioned this pull request Apr 8, 2025
Merged
@sayboras
Copy link
Member Author

sayboras commented Apr 8, 2025

/test

@sayboras sayboras enabled auto-merge April 8, 2025 14:31
@sayboras sayboras added this pull request to the merge queue Apr 8, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 8, 2025
Merged via the queue into main with commit f7e28de Apr 8, 2025
227 checks passed
@sayboras sayboras deleted the pr/tammach/correct-version-check-exp branch April 8, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brlbil brlbil brlbil approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayboras @brlbil