Skip to content

connectivity: Fix flow validation for wildcard tls sni #38881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

sayboras
Copy link
Member

This commit is to update the expectation to fix the flow validation failure in cilium/proxy CI.

Relates: https://github.com/cilium/proxy/actions/runs/14384792950/job/40337349500
Fixes: f636909

@maintainer-s-little-helper
Copy link

Commit 5924678 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 11, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Apr 11, 2025
This commit is to update the expectation to fix the flow validation
failure in cilium/proxy CI.

Relates: https://github.com/cilium/proxy/actions/runs/14384792950/job/40337349500
Fixes: f636909
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/sni-flow-validation branch from 5924678 to 361e06f Compare April 11, 2025 04:05
@maintainer-s-little-helper
Copy link

Commit 5924678 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@sayboras sayboras added release-note/ci This PR makes changes to the CI. and removed dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 11, 2025
@sayboras sayboras changed the title connectivity: Fix flow validation for wildcard tls connectivity: Fix flow validation for wildcard tls sni Apr 11, 2025
@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review April 11, 2025 05:09
@sayboras sayboras requested a review from a team as a code owner April 11, 2025 05:09
@sayboras sayboras requested a review from jrajahalme April 11, 2025 06:25
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jrajahalme jrajahalme added this pull request to the merge queue Apr 11, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 11, 2025
Merged via the queue into main with commit 6e5a74f Apr 11, 2025
225 checks passed
@jrajahalme jrajahalme deleted the pr/tammach/sni-flow-validation branch April 11, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants