cilium-cli: add annotation to indicate we should wait for policy #38867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
derailed
reviewed
Apr 10, 2025
The connectivity tests wait for policy changes to roll out; they do so by counting the number of policy resources and waiting for each agent's revision to be incremented by that number. There are, however, other resources or actions that can cause policy revision bumps such as config changes or CiliumEnvoyConfigs. Rather than coding them all in, enable a special annotation that triggers this. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
9d03041 to
8e59744
Compare
|
/test |
derailed
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connectivity tests wait for policy changes to roll out; they do so by counting the number of policy resources and waiting for each agent's revision to be incremented by that number.
There are, however, other resources or actions that can cause policy revision bumps such as config changes or CiliumEnvoyConfigs. Rather than coding them all in, enable a special annotation that triggers this.