Skip to content

chore(hubble-ui): Silence access log produced by readinessProbe #38725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

chore(hubble-ui): Silence access log produced by readinessProbe #38725

merged 1 commit into from
May 14, 2025

Conversation

mkilchhofer
Copy link
Contributor

@mkilchhofer mkilchhofer commented Apr 3, 2025 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

This is a little follow-up of my contribution ~2years ago:

Without this change, you see a lot of those lines inside the log:

(..)
10.42.1.32 - - [03/Apr/2025:19:23:37 +0000] "GET / HTTP/1.1" 200 702 "-" "kube-probe/1.31" "-"
10.42.1.32 - - [03/Apr/2025:19:23:45 +0000] "GET / HTTP/1.1" 200 702 "-" "kube-probe/1.31" "-"
(..)

With the change, these lines will not appear since we silence them based on the kubelet's User-Agent.

Release note entry:

ReadinessProbe of Hubble-ui no longer produces unnecessary access log entries inside the frontend container.

@mkilchhofer mkilchhofer requested review from a team as code owners April 3, 2025 19:26
@mkilchhofer mkilchhofer requested review from joamaki, squeed and glrf April 3, 2025 19:26
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 3, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Apr 3, 2025
@glrf glrf added kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. area/hubble Impacts hubble server or relay labels Apr 8, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 8, 2025
glrf
glrf approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@glrf glrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At first I was concerned that disabling access log based on user agent could be a security issue, but that doesn't apply to the api, so I think this should be fine.

I'd still like to have a review from the Hubble UI team, though.

@glrf glrf requested a review from geakstr April 8, 2025 07:15
@squeed squeed added the dont-merge/discussion A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status. label Apr 9, 2025
@squeed
Copy link
Contributor

squeed commented Apr 9, 2025

Looks good to me. I've tagged this with dont-merge/discussion until we hear from @geakstr, as their review is non-blocking. Feel free to remove it when appropriate.

@squeed
Copy link
Contributor

squeed commented Apr 9, 2025

/test

@joestringer
Copy link
Member

Hey @geakstr , did you get a chance to review this change? Does it make sense to you?

@joestringer
Copy link
Member

FWIW the ci-ginkgo failures look like a particular failure in the main branch from a couple of weeks ago. Most likely rebasing would fix that up. But for now I think we're mainly just waiting on review feedback.

@aanm aanm force-pushed the feature/add_probes_for_hubble-ui_disable_accesslog branch from e4ae8ef to 44f4e1c Compare April 29, 2025 09:03
@aanm aanm enabled auto-merge April 29, 2025 09:03
@aanm
Copy link
Member

aanm commented Apr 29, 2025

/test

@mkilchhofer @aanm
chore(hubble-ui): Silence access log produced by readinessProbe
d871c65 
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
@aanm aanm force-pushed the feature/add_probes_for_hubble-ui_disable_accesslog branch from 44f4e1c to d871c65 Compare May 8, 2025 09:20
@aanm
Copy link
Member

aanm commented May 8, 2025

/test

@julianwiedmann
Copy link
Member

Looks good to me. I've tagged this with dont-merge/discussion until we hear from @geakstr, as their review is non-blocking. Feel free to remove it when appropriate.

Removing this now, as @geakstr added his ✔️.

@julianwiedmann julianwiedmann removed the dont-merge/discussion A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status. label May 13, 2025
@aanm aanm added this pull request to the merge queue May 13, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2025
@julianwiedmann julianwiedmann added this pull request to the merge queue May 14, 2025
Merged via the queue into cilium:main with commit d030248 May 14, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@joamaki joamaki joamaki approved these changes

@geakstr geakstr geakstr approved these changes

@glrf glrf glrf approved these changes

Assignees
No one assigned
Labels
area/hubble Impacts hubble server or relay kind/community-contribution This was a contribution made by a community member. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mkilchhofer @squeed @joestringer @aanm @julianwiedmann @joamaki @geakstr @glrf