Skip to content

cilium-cli: Allow BINDIR environment variable to be dynamically configured for install path #38799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

cilium-cli: Allow BINDIR environment variable to be dynamically configured for install path #38799

merged 1 commit into from
Apr 16, 2025

Conversation

mowntan
Copy link
Contributor

@mowntan mowntan commented Apr 8, 2025 •
edited
Loading

Added ?= to BINDIR variable to assign only if it's not set/doesn't have a value.

Fixes: #38786

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@mowntan mowntan requested a review from a team as a code owner April 8, 2025 01:58
@mowntan mowntan requested a review from tommyp1ckles April 8, 2025 01:58
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 8, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary kind/community-contribution This was a contribution made by a community member. labels Apr 8, 2025
@joestringer joestringer changed the title Cilium Cli Makefile does not accept BINDIR environment variable cilium-cli: Allow BINDIR environment variable to be dynamically configured for install path Apr 8, 2025
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Apr 8, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 8, 2025
@joestringer joestringer closed this Apr 8, 2025
@joestringer joestringer reopened this Apr 8, 2025
@joestringer
Copy link
Member

/test

@joestringer joestringer enabled auto-merge April 8, 2025 20:31
HadrienPatte
HadrienPatte reviewed Apr 9, 2025
View reviewed changes
auto-merge was automatically disabled April 11, 2025 19:29

Head branch was pushed to by a user without write access

@joestringer joestringer reopened this Apr 12, 2025
@joestringer
Copy link
Member

/test

@joestringer joestringer enabled auto-merge April 12, 2025 17:35
@joestringer joestringer disabled auto-merge April 16, 2025 15:27
@mowntan @HadrienPatte @joestringer
Makefile: Support installing to custom paths with BINDIR
c128f79 
Signed-off-by: Jeremy Young <mowntan@gmail.com>
Co-authored-by: Hadrien Patte <hadrien.patte@protonmail.com>
@joestringer joestringer force-pushed the fix-cilium-cli-bindir-environment-variable branch from d14557b to c128f79 Compare April 16, 2025 16:15
@joestringer
Copy link
Member

Thanks for the contribution! CI tests passed. I squashed the commit together and repushed, will merge shortly.

@joestringer joestringer merged commit e6dc4d5 into cilium:main Apr 16, 2025
2 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HadrienPatte HadrienPatte HadrienPatte left review comments

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cilium Cli Makefile does not accept BINDIR environment variable
4 participants
@mowntan @joestringer @tommyp1ckles @HadrienPatte