cli: sysdump: collect logs from restarted test pods. #38796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
|
/test |
derailed
approved these changes
Apr 10, 2025
Currently only crash-loop pods are included in the test pod crash log sysdump task. However, we are also interested in test pods crashing once, such as in the case of a uncommon panic bug, that may not trigger a crash loop. This change will also get logs for Pods that have been restarted to be included in the sysdump task. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
8fd3069 to
70d1f12
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only crash-loop pods are included in the test pod crash log sysdump task.
However, we are also interested in test pods crashing once, such as in the case of a uncommon panic bug, that may not trigger a crash loop.
This change will also get logs for Pods that have
been restarted to be included in the sysdump task.