ci/workflows: disable github workflows on forks #38791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
26b4660 to
c258cf3
Compare
8f12dd4 to
6708f02
Compare
With
|
thorn3r
reviewed
Apr 9, 2025
There was a problem hiding this comment.
I like the idea and intent behind this change, but I wonder if there's a more robust way to enforce it (maybe Ariane or some clever reusable action). This might work fine for now, but it seems likely it will get missed/forgotten on some future workflow or the addition of a new job.
|
@thorn3r Thank you for your input.
I can understand and somewhat agree that this might be overlooked, and there could be another smarter way to do it and fully open to it. However, for now, do you think we could adjust the workflows as a quick win? |
joestringer
reviewed
Apr 21, 2025
5a465d9 to
d055295
Compare
…l switch Signed-off-by: ishuar <ishansharma887@gmail.com>
d055295 to
914064b
Compare
ishuar
commented
May 5, 2025
aanm
approved these changes
May 6, 2025
|
/test |
|
Thanks for the improvement @ishuar 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable GitHub Workflows on Forks by Default
Problem Statement
Currently, GitHub workflows are triggered on forked repositories, resulting in:
While GitHub provides an option to completely or selectively disable Actions on forks, this approach is restrictive and prevents users from using workflows on their forks for legitimate use cases.
Proposed Solution (Explicit Deny over Allow All)
This PR proposes changes to the GitHub workflows to explicitly configure them to run only when the project owner is cilium. By adding this condition, workflows will:
Run only on the cilium/cilium repository by default.
Prevent triggering workflows on forks, saving unnecessary usage and avoiding email spam.
If a fork owner wishes to run workflows, they can still modify the workflow configurations on their fork as needed.
Benefits
Additional Context
Attached below are screenshots of the email notifications and workflow runs triggered on my fork to illustrate the problem being addressed by this PR.