Skip to content

Fix the message when no nodes are available to be added multicast group. #38637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

Fix the message when no nodes are available to be added multicast group. #38637

merged 1 commit into from
May 1, 2025

Conversation

fujitatomoya
Copy link
Contributor

@fujitatomoya fujitatomoya commented Mar 31, 2025 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

Fix the message when no nodes are available to be added multicast group.

@fujitatomoya fujitatomoya requested a review from a team as a code owner March 31, 2025 17:04
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 31, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary kind/community-contribution This was a contribution made by a community member. labels Mar 31, 2025
fujitatomoya
fujitatomoya commented Mar 31, 2025
View reviewed changes
@nathanjsweet nathanjsweet added the release-note/misc This PR makes changes that have no direct user impact. label Apr 2, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 2, 2025
nathanjsweet
nathanjsweet approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@nathanjsweet nathanjsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nathanjsweet
Copy link
Member

/test

@nathanjsweet nathanjsweet enabled auto-merge April 16, 2025 15:21
@maintainer-s-little-helper
Copy link

Commit ffd4dae does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Apr 17, 2025
auto-merge was automatically disabled April 17, 2025 15:46

Head branch was pushed to by a user without write access

@fujitatomoya fujitatomoya force-pushed the multicast-message-adjustment branch from ffd4dae to da77310 Compare April 17, 2025 15:46
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Apr 17, 2025
@fujitatomoya
Copy link
Contributor Author

@nathanjsweet i just rebased, and CI just got started.

@joestringer
Copy link
Member

/test

@joestringer joestringer enabled auto-merge April 21, 2025 21:51
@ldelossa
Copy link
Contributor

ldelossa commented May 1, 2025

@fujitatomoya can you please rebase this PR, there is a consistently failing CI test which is unrelated to the change. Lets rebase the latest changes in main and run CI again.

@fujitatomoya
Fix the message when no nodes are available to be added multicast group.
7c3cfa6 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
auto-merge was automatically disabled May 1, 2025 16:28

Head branch was pushed to by a user without write access

@fujitatomoya fujitatomoya force-pushed the multicast-message-adjustment branch from da77310 to 7c3cfa6 Compare May 1, 2025 16:28
@fujitatomoya
Copy link
Contributor Author

@ldelossa done rebase. quick question, do we have something like Mergifyio thing to do these rebase operation.

@joestringer
Copy link
Member

There's this button:
image .

I'm not sure there's a viable way to set up an automated system for this due to the scale of the problem.

@joestringer
Copy link
Member

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 1, 2025
@fujitatomoya
Copy link
Contributor Author

@joestringer thanks! that is what i was asking for!

@joestringer joestringer added this pull request to the merge queue May 1, 2025
@joestringer
Copy link
Member

joestringer commented May 1, 2025 •
edited
Loading

Queued to merge. @fujitatomoya Please also update the PR description. The text like the below is intended for you to either delete or write a user-facing release note. If you remove it, we will use the PR title.

<!-- Enter the release note text here if needed or remove this section! -->

Merged via the queue into cilium:main with commit 570f0e6 May 1, 2025
65 of 66 checks passed
@fujitatomoya
Copy link
Contributor Author

@joestringer done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet nathanjsweet approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fujitatomoya @nathanjsweet @joestringer @ldelossa