Skip to content

cilium-cli: run IPv6 test with skipRedirectFromBackend=true on >=v1.17.3 #38630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2025
Merged

cilium-cli: run IPv6 test with skipRedirectFromBackend=true on >=v1.17.3 #38630

merged 3 commits into from
Apr 3, 2025

Conversation

ysksuzuki
Copy link
Member

@ysksuzuki ysksuzuki commented Mar 31, 2025 •
edited
Loading

Run the IPv6 test with skipRedirectFromBackend=true only on Cilium v1.17.3 and newer, where the port endianness issue in NewSkipLB6Key() was fixed (commit b29fdd2).

Also this PR ensure that cilium-cli skips to apply CLRPs with ipv6 frontend if ipv6 is disabled to avoid the agent crash caused by #38570

@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Mar 31, 2025
@ysksuzuki ysksuzuki mentioned this pull request Mar 31, 2025
Merged
@ysksuzuki ysksuzuki added release-note/ci This PR makes changes to the CI. area/lrp Impacts Local Redirect Policy. labels Mar 31, 2025
@ysksuzuki ysksuzuki force-pushed the run-lrp-test-ipv6-1.17.3 branch from a09a0e8 to 6e07180 Compare April 1, 2025 23:32
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki ysksuzuki marked this pull request as ready for review April 2, 2025 01:07
@ysksuzuki ysksuzuki requested review from a team as code owners April 2, 2025 01:07
ysksuzuki added 3 commits April 2, 2025 18:32
@ysksuzuki
cilium-cli: refactor lrp test
805ad74 
Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
@ysksuzuki
cilium-cli: run IPv6 test with skipRedirectFromBackend=true >=v1.17.3
5106c50 
Run the IPv6 test with skipRedirectFromBackend=true only on
Cilium v1.17.3 and newer, where the port endianness issue in
NewSkipLB6Key() was fixed. (commit b29fdd2).

Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
@ysksuzuki
cilium-cli: skip to apply CLRP with ipv6 frontend if ipv6 disabled
cc5010c 
This commit ensure that cilium-cli skips to apply CLRP with
ipv6 frontend if ipv6 is disabled to avoid the agent crash
caused by cilium#38570

Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
@ysksuzuki ysksuzuki force-pushed the run-lrp-test-ipv6-1.17.3 branch from 6e07180 to cc5010c Compare April 2, 2025 09:32
@ysksuzuki
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 2, 2025
@michi-covalent michi-covalent added this pull request to the merge queue Apr 3, 2025
Merged via the queue into cilium:main with commit 67ceb81 Apr 3, 2025
67 checks passed
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandreimerink dylandreimerink dylandreimerink approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
area/lrp Impacts Local Redirect Policy. cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ysksuzuki @dylandreimerink @christarazi @michi-covalent