Skip to content

cilium-cli: add conn tests for ipv6 egress gateway policies #38691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

cilium-cli: add conn tests for ipv6 egress gateway policies #38691

merged 3 commits into from
Apr 25, 2025

Conversation

rgo3
Copy link
Contributor

@rgo3 rgo3 commented Apr 2, 2025 •
edited
Loading

As a follow up to #38452, this PR adds the ability to list IPv6 EGW policies with cilium-dbg and the necessary cilium-cli connectivity tests to enable e2e test for the IPv6 extension of EGW policies.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 2, 2025
@github-actions github-actions bot added the cilium-cli This PR contains changes related with cilium-cli label Apr 2, 2025
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 2, 2025

/ci-e2e-upgrade

@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch from 44cd78b to fc5862b Compare April 3, 2025 09:38
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 3, 2025

/ci-e2e-upgrade

@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch from fc5862b to bb6f14f Compare April 3, 2025 12:53
@rgo3 rgo3 mentioned this pull request Apr 3, 2025
Merged
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 3, 2025

/ci-e2e-upgrade

@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch from bb6f14f to ff25dfc Compare April 3, 2025 19:33
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 3, 2025

/ci-e2e-upgrade

@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch 2 times, most recently from 8e6a1f2 to 1b17c9f Compare April 16, 2025 10:25
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 16, 2025

/ci-e2e-upgrade

@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch from 1b17c9f to aedf950 Compare April 16, 2025 13:47
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 16, 2025

/ci-e2e-upgrade

@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch from aedf950 to 7ec5c20 Compare April 16, 2025 22:18
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 16, 2025

/ci-e2e-upgrade

@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch from 7ec5c20 to 1ff68ee Compare April 16, 2025 22:49
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 16, 2025

/ci-e2e-upgrade

@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch from 1ff68ee to d5c7154 Compare April 17, 2025 08:31
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 17, 2025

/ci-e2e-upgrade

@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch from d5c7154 to 49e18b5 Compare April 17, 2025 09:41
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 17, 2025

/ci-e2e-upgrade

@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch from 49e18b5 to e21bd42 Compare April 17, 2025 12:27
@rgo3 rgo3 changed the title Pr/rgo3/ipv6 egw conn tests cilium-cli: add conn tests for ipv6 egress gateway policies Apr 17, 2025
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 17, 2025

/ci-e2e-upgrade

@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch from e21bd42 to b6e57ea Compare April 17, 2025 14:18
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 17, 2025

/ci-e2e-upgrade

@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch from b6e57ea to ea98423 Compare April 21, 2025 13:17
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 21, 2025

/ci-e2e-upgrade

@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch from ea98423 to 74688ff Compare April 22, 2025 07:31
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 22, 2025

/test

@rgo3 rgo3 marked this pull request as ready for review April 22, 2025 11:51
@rgo3 rgo3 requested review from a team as code owners April 22, 2025 11:52
@rgo3 rgo3 added release-note/misc This PR makes changes that have no direct user impact. feature/egress-gateway Impacts the egress IP gateway feature. labels Apr 22, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 22, 2025
rgo3
rgo3 commented Apr 22, 2025
View reviewed changes
ysksuzuki
ysksuzuki reviewed Apr 23, 2025
View reviewed changes
Copy link
Member

@ysksuzuki ysksuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks! Just two questions.

rgo3 added 3 commits April 24, 2025 12:28
@rgo3
cilium-dbg: list ipv6 egress policy entries
260b91d 
Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
@rgo3
cilium-cli: fix ipv6 nodeport service address
3995855 
This commit fixes a bug where the address returned for a NodePort
Service could be a IPv4 address while the requested family was IPv6.

Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
@rgo3
cilium-cli: add conn tests for ipv6 egress gateway policies
742b42a 
With this commit the cilium-cli can test if IPv6 egress gateway policies
function as expected. These test will only run if the cluster has a
dual-stack setup and runs at least cilium version 1.18.

Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
@rgo3 rgo3 force-pushed the pr/rgo3/ipv6-egw-conn-tests branch from 74688ff to 742b42a Compare April 24, 2025 10:33
@rgo3
Copy link
Contributor Author

rgo3 commented Apr 24, 2025

/test

ysksuzuki
ysksuzuki approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@ysksuzuki ysksuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

viktor-kurchenko
viktor-kurchenko approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 24, 2025
@joestringer joestringer added this pull request to the merge queue Apr 25, 2025
Merged via the queue into main with commit a172b62 Apr 25, 2025
332 of 336 checks passed
@joestringer joestringer deleted the pr/rgo3/ipv6-egw-conn-tests branch April 25, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@ysksuzuki ysksuzuki ysksuzuki approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli feature/egress-gateway Impacts the egress IP gateway feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rgo3 @tklauser @ysksuzuki @viktor-kurchenko @joestringer