Skip to content

Drop WireGuard encryption strict mode Ginkgo test #38538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

Drop WireGuard encryption strict mode Ginkgo test #38538

merged 1 commit into from
Mar 28, 2025

Conversation

pippolo84
Copy link
Member

@pippolo84 pippolo84 commented Mar 26, 2025 •
edited
Loading

A cilium-cli test already exists to verify that there are no unencrypted leaks in WireGuard strict mode, thus it is safe to remove the now redundant Ginkgo one.

Related: #35231

@pippolo84 pippolo84 added area/CI Continuous Integration testing issue or flake area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. feature/wireguard Relates to Cilium's Wireguard feature labels Mar 26, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 26, 2025
@pippolo84 pippolo84 changed the title test: Drop WireGuard encryption strict mode test Drop WireGuard encryption strict mode Ginkgo test Mar 26, 2025
@pippolo84
Copy link
Member Author

/test

@pippolo84
test: Drop WireGuard encryption strict mode test
8d07e24 
A cilium-cli test already exists to verify that there are no unencrypted
leaks in WireGuard strict mode, thus it is safe to remove the now
redundant Ginkgo one.

Related: cilium#35231

Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
@pippolo84 pippolo84 force-pushed the pr/pippolo84/drop-ginkgo-wg-strict-mode branch from 501b7a7 to 8d07e24 Compare March 27, 2025 15:42
@pippolo84
Copy link
Member Author

/ci-ginkgo

@pippolo84 pippolo84 added the release-note/ci This PR makes changes to the CI. label Mar 27, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 27, 2025
@pippolo84 pippolo84 removed the area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. label Mar 27, 2025
@pippolo84 pippolo84 marked this pull request as ready for review March 27, 2025 18:27
@pippolo84 pippolo84 requested review from a team as code owners March 27, 2025 18:27
@pippolo84 pippolo84 requested review from gentoo-root and Artyop March 27, 2025 18:27
@pippolo84 pippolo84 mentioned this pull request Mar 27, 2025
Merged
@pippolo84
Copy link
Member Author

/test

@pippolo84 pippolo84 mentioned this pull request Mar 28, 2025
Open
@pippolo84
Copy link
Member Author

ci-runtime hit #38574, rerunning

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 28, 2025
@giorio94 giorio94 added this pull request to the merge queue Mar 28, 2025
Merged via the queue into cilium:main with commit 49033fe Mar 28, 2025
77 checks passed
@pippolo84 pippolo84 added the affects/v1.17 This issue affects v1.17 branch label Apr 4, 2025
julianwiedmann added a commit that referenced this pull request May 26, 2025
@julianwiedmann
test: remove stale error log exception
1646cd7 
#38538 removed the problematic test.

Fixes: #29715
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request May 28, 2025
@julianwiedmann
test: remove stale error log exception
6f79a27 
#38538 removed the problematic test.

Fixes: #29715
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
zzuckerfrei pushed a commit to zzuckerfrei/cilium that referenced this pull request May 29, 2025
@julianwiedmann @zzuckerfrei
test: remove stale error log exception
ee3fea3 
cilium#38538 removed the problematic test.

Fixes: cilium#29715
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentoo-root gentoo-root gentoo-root approved these changes

@Artyop Artyop Artyop approved these changes

Assignees
No one assigned
Labels
affects/v1.17 This issue affects v1.17 branch area/CI Continuous Integration testing issue or flake area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. feature/wireguard Relates to Cilium's Wireguard feature ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pippolo84 @gentoo-root @Artyop @giorio94