Introduce --underlay-protocol
#38523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
reviewed
Mar 27, 2025
derailed
approved these changes
Mar 28, 2025
1a727c2 to
072873d
Compare
dylandreimerink
approved these changes
Apr 1, 2025
072873d to
c76257e
Compare
squeed
approved these changes
Apr 2, 2025
This renaming is simply preparatory work for the next commit, which will introduce a different kind of protocol choice related to our tunnels: underlay protocols. There are no functional changes in this commit. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
This new flag allows chosing the underlay protocol for our VXLAN or GENEVE overlay. It will be used in subsequent commits when deciding which IP address to use for tunnel endpoints. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
Support for the IPv6 tunneling underlay doesn't yet include support for KPR (and all related features), IPsec, or WireGuard. Let's error out in the agent if such a combination of options is given. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
This new Helm option sets --underlay-protocol, to configure the underlay protocol for our VXLAN or GENEVE tunnels. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
c76257e to
0628399
Compare
wanglei4687
pushed a commit
to wanglei4687/cilium
that referenced
this pull request
Jun 26, 2025
Now that the long standing tunneling + IPv6-only limitation has been lifted [1,2,3], let's enable this previously commented-out matrix entry of the conformance-clustermesh workflow. [1]: cilium#38523 [2]: cilium#38296 [3]: cilium#39074 Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new tunneling flag called
underlay-protocol. This new flag isn't doing anything in this pull request, but will be used in a ready-to-go follow up PR (I'm simply splitting to ease reviews). This new flag will allow us to select IPv6 as the underlay for our tunnels.