Skip to content

Use slices.Sorted(maps.Keys(...)) to get sorted list of map keys #38519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

Use slices.Sorted(maps.Keys(...)) to get sorted list of map keys #38519

merged 1 commit into from
Apr 3, 2025

Conversation

tklauser
Copy link
Member

Use convenience functions provided in the Go standard library maps and slices packages to reduce boilerplate code.

@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Mar 26, 2025
@tklauser tklauser requested review from a team as code owners March 26, 2025 10:37
@tklauser
Copy link
Member Author

/test

@tklauser tklauser enabled auto-merge March 26, 2025 10:37
@github-actions github-actions bot added the cilium-cli This PR contains changes related with cilium-cli label Mar 26, 2025
@tklauser tklauser force-pushed the pr/tklauser/maps-keys-sorted branch from b1f5857 to 9b8f693 Compare March 26, 2025 10:47
@tklauser
Copy link
Member Author

/test

@tklauser tklauser force-pushed the pr/tklauser/maps-keys-sorted branch 2 times, most recently from 82af30f to e7375cc Compare March 26, 2025 11:03
@tklauser tklauser requested review from a team as code owners March 26, 2025 11:03
@tklauser tklauser requested a review from glrf March 26, 2025 11:03
@tklauser
Use slices.Sorted(maps.Keys(...)) to get sorted list of map keys
2c5c91e 
Use convenience functions provided in the Go standard library maps and
slices packages to reduce boilerplate code.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/tklauser/maps-keys-sorted branch from e7375cc to 2c5c91e Compare March 26, 2025 11:14
@tklauser
Copy link
Member Author

/test

giorio94
giorio94 approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for my codeowners, thanks!

mhofstetter
mhofstetter approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

derailed
derailed approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tklauser Nice work!

aditighag
aditighag approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for sig-lb

@tklauser
Copy link
Member Author

tklauser commented Apr 1, 2025

/test

@tklauser tklauser added this pull request to the merge queue Apr 3, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 3, 2025
Merged via the queue into main with commit 4559c00 Apr 3, 2025
345 of 369 checks passed
@tklauser tklauser deleted the pr/tklauser/maps-keys-sorted branch April 3, 2025 13:35
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

@ti-mo ti-mo ti-mo approved these changes

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

@mhofstetter mhofstetter mhofstetter approved these changes

@bimmlerd bimmlerd bimmlerd approved these changes

@youngnick youngnick youngnick approved these changes

@glrf glrf glrf approved these changes

@rastislavs rastislavs rastislavs approved these changes

@aditighag aditighag aditighag approved these changes

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.