Skip to content

pkg/bpf: migrate to slog #38518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

pkg/bpf: migrate to slog #38518

merged 1 commit into from
May 6, 2025

Conversation

aanm
Copy link
Member

@aanm aanm commented Mar 26, 2025

Note for reviewers: because this PR is opened against pr/move-maps-to-slog, then once the changes are approved we can merge the PR to the pr/move-maps-to-slog or change the base and point it to main.

@aanm aanm added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. feature/slog labels Mar 26, 2025
@maintainer-s-little-helper
Copy link

Commit 6f507b6 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 26, 2025
@github-actions github-actions bot added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label Mar 26, 2025
@aanm
Copy link
Member Author

aanm commented Mar 26, 2025

/ci-runtime

@aanm aanm force-pushed the pr/move-bpf-to-slog branch from ab53dd4 to c7dd0bb Compare March 26, 2025 10:32
@maintainer-s-little-helper
Copy link

Commit 6f507b6 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@aanm
Copy link
Member Author

aanm commented Mar 26, 2025

/ci-runtime

@aanm aanm force-pushed the pr/move-bpf-to-slog branch from c7dd0bb to 1dbd756 Compare March 26, 2025 11:29
@maintainer-s-little-helper
Copy link

Commit 6f507b6 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@aanm
Copy link
Member Author

aanm commented Mar 26, 2025

/ci-runtime

@aanm aanm force-pushed the pr/move-bpf-to-slog branch from 1dbd756 to f7d50cd Compare March 26, 2025 12:32
@maintainer-s-little-helper
Copy link

Commit ff2cab2 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@aanm
Copy link
Member Author

aanm commented Mar 26, 2025

/ci-runtime

1 similar comment
@aanm
Copy link
Member Author

aanm commented Mar 26, 2025

/ci-runtime

@aanm aanm force-pushed the pr/move-bpf-to-slog branch from f7d50cd to 6b2dbab Compare March 26, 2025 12:50
@maintainer-s-little-helper
Copy link

Commit ff2cab2 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@aanm
Copy link
Member Author

aanm commented Mar 26, 2025

/ci-runtime

@aanm
Copy link
Member Author

aanm commented Mar 26, 2025

/test

@aanm aanm force-pushed the pr/move-bpf-to-slog branch from 6b2dbab to 0ddea3a Compare April 4, 2025 05:20
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Apr 4, 2025
@aanm
Copy link
Member Author

aanm commented Apr 4, 2025

/test

@aanm aanm force-pushed the pr/move-bpf-to-slog branch from 0ddea3a to 6d8a3d2 Compare April 4, 2025 05:51
@aanm
Copy link
Member Author

aanm commented Apr 4, 2025

/test

@aanm aanm changed the base branch from main to pr/move-maps-to-slog April 4, 2025 11:57
@aanm aanm force-pushed the pr/move-bpf-to-slog branch from 6d8a3d2 to cba5341 Compare April 4, 2025 11:59
@aanm
Copy link
Member Author

aanm commented Apr 4, 2025

/test

@aanm aanm marked this pull request as ready for review April 4, 2025 12:00
@aanm aanm force-pushed the pr/move-maps-to-slog branch 2 times, most recently from 73a46cc to bb6c98b Compare April 23, 2025 07:59
@aanm aanm force-pushed the pr/move-bpf-to-slog branch from fe63fd0 to 186e1f5 Compare April 23, 2025 08:00
@aanm aanm changed the base branch from pr/move-maps-to-slog to main April 23, 2025 09:25
@aanm
Copy link
Member Author

aanm commented Apr 23, 2025

/test

Migrate this package to use slog instead of logrus.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/move-bpf-to-slog branch from 186e1f5 to 2c447d5 Compare May 6, 2025 11:36
@aanm
Copy link
Member Author

aanm commented May 6, 2025

/test

@aanm aanm marked this pull request as ready for review May 6, 2025 11:37
@aanm aanm enabled auto-merge May 6, 2025 11:37
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 6, 2025
@aanm aanm added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit 84d5204 May 6, 2025
297 of 298 checks passed
@aanm aanm deleted the pr/move-bpf-to-slog branch May 6, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. feature/slog ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants