Skip to content

Conversation

giorio94
Copy link
Member

Issues mechanically fixed via:

#!/bin/bash

while read -r LINTER; do

[[ ${LINTER} =~ ^# ]] && continue

testifylint --fix --disable-all --enable ${LINTER} ./...
git status -s | awk '{ print $2}' | xargs -r goimports -w

git add .
git commit --signoff -F- <<EOF
treewide(tests): testifylint "${LINTER}" fixes

Generated by:

    testifylint --fix --disable-all --enable ${LINTER} ./...
EOF

done <<-EOF
empty
equal-values
expected-actual
formatter
len
suite-method-signature
useless-assert
EOF

Related: #35237
Related: #38473

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 25, 2025
@github-actions github-actions bot added sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. cilium-cli This PR contains changes related with cilium-cli labels Mar 25, 2025
@giorio94 giorio94 added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Mar 25, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 25, 2025
@giorio94
Copy link
Member Author

/ci-integration

@giorio94
Copy link
Member Author

/ci-runtime

@giorio94
Copy link
Member Author

/test

@giorio94 giorio94 marked this pull request as ready for review March 25, 2025 12:50
@giorio94 giorio94 requested review from a team as code owners March 25, 2025 12:50
@giorio94
Copy link
Member Author

@jrajahalme @ti-mo @squeed @christarazi Gentle ping 🙏 (this PR is easily subject to (silent) conflicts).

@giorio94
Copy link
Member Author

/test

Copy link
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, opened this on mobile a few days ago which removed the notification. Thanks!

@giorio94 giorio94 removed the request for review from squeed March 27, 2025 16:52
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 1, 2025
@tklauser tklauser added dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Apr 1, 2025
@tklauser
Copy link
Member

tklauser commented Apr 1, 2025

@giorio94 looks like this PR picked up a merge conflict and needs a rebase.

@giorio94
Copy link
Member Author

giorio94 commented Apr 1, 2025

/test

@giorio94 giorio94 removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Apr 1, 2025
giorio94 added 7 commits April 2, 2025 17:50
Drop the leftover 0, which would have made the assertion useless.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Generated by:

    testifylint --fix --disable-all --enable empty ./...

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Generated by:

    testifylint --fix --disable-all --enable equal-values ./...

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Generated by:

    testifylint --fix --disable-all --enable formatter ./...

Slightly edited manually where appropriate to obtain more meaningful
changes.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Generated by:

    testifylint --fix --disable-all --enable len ./...

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Manually address the issues reported by the "useless-assert" testify
linter.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
This reverts commit e809795.

Now that the issues have been addressed, let's enable these linters again.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94
Copy link
Member Author

giorio94 commented Apr 2, 2025

Rebased to hopefully make CI happier.

@giorio94
Copy link
Member Author

giorio94 commented Apr 2, 2025

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 3, 2025
@giorio94 giorio94 added this pull request to the merge queue Apr 3, 2025
Merged via the queue into cilium:main with commit 779fe3f Apr 3, 2025
65 of 67 checks passed
@giorio94 giorio94 deleted the mio/testifylint branch April 3, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cilium-cli This PR contains changes related with cilium-cli kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.