-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Enable new testifylint checks, and mechanically fix reported issues #38485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/ci-integration |
/ci-runtime |
/test |
d672bbf
to
e8986ac
Compare
@jrajahalme @ti-mo @squeed @christarazi Gentle ping 🙏 (this PR is easily subject to (silent) conflicts). |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, opened this on mobile a few days ago which removed the notification. Thanks!
@giorio94 looks like this PR picked up a merge conflict and needs a rebase. |
e8986ac
to
26e2eba
Compare
/test |
Drop the leftover 0, which would have made the assertion useless. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Generated by: testifylint --fix --disable-all --enable empty ./... Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Generated by: testifylint --fix --disable-all --enable equal-values ./... Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Generated by: testifylint --fix --disable-all --enable formatter ./... Slightly edited manually where appropriate to obtain more meaningful changes. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Generated by: testifylint --fix --disable-all --enable len ./... Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Manually address the issues reported by the "useless-assert" testify linter. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
This reverts commit e809795. Now that the issues have been addressed, let's enable these linters again. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
26e2eba
to
f153d2f
Compare
Rebased to hopefully make CI happier. |
/test |
Issues mechanically fixed via:
Related: #35237
Related: #38473